Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 ) Change subject: osmux: Introduce API osmux_xfrm_input_set_name() ...................................................................... Patch Set 2: (3 comments) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/fed96bae_58a068c5 PS2, Line 732: link->name = talloc_asprintf(link, "%p", h); To identify the different links by default without the user having to add a name (hence being able to identify links in old users not using the name() API). https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/5c5410e1_c0baa669 PS2, Line 777: osmo_talloc_replace_string(link, &link->name, name); See my other comment in my answer. File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/7b0d4652_76cbe965 PS2, Line 14: # Following sed gets rid of pointer addresses to have reproducible output: Yeah, backward compatibility is though ;) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6 Gerrit-Change-Number: 30210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Nov 2022 15:23:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment