Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30210 )

Change subject: osmux: Introduce API osmux_xfrm_input_set_name() ......................................................................

Patch Set 2:

(3 comments)

File src/osmux_input.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/fed96bae_58a068c5 PS2, Line 732: link->name = talloc_asprintf(link, "%p", h);

What's the point of printing pointer as name in here?

To identify the different links by default without the user having to add a name (hence being able to identify links in old users not using the name() API).

https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/5c5410e1_c0baa669 PS2, Line 777: osmo_talloc_replace_string(link, &link->name, name);

If it will be replaced with actual name in here? […]

See my other comment in my answer.

File tests/testsuite.at:

https://gerrit.osmocom.org/c/libosmo-netif/+/30210/comment/7b0d4652_76cbe965 PS2, Line 14: # Following sed gets rid of pointer addresses to have reproducible output:

This looks like complex, hard to read and maintain solution for the problem introduced in the very s […]

Yeah, backward compatibility is though ;)