Attention is currently required from: msuraev.

View Change

3 comments:

• File src/osmux_input.c:

  • Patch Set #2, Line 732: link->name = talloc_asprintf(link, "%p", h);

    What's the point of printing pointer as name in here?

    To identify the different links by default without the user having to add a name (hence being able to identify links in old users not using the name() API).

  • Patch Set #2, Line 777: osmo_talloc_replace_string(link, &link->name, name);

    If it will be replaced with actual name in here? […]

    See my other comment in my answer.

• File tests/testsuite.at:

  • Patch Set #2, Line 14: # Following sed gets rid of pointer addresses to have reproducible output:

    This looks like complex, hard to read and maintain solution for the problem introduced in the very s […]

    Yeah, backward compatibility is though ;)

To view, visit change 30210. To unsubscribe, or for help writing mail filters, visit settings.