Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32075 ) Change subject: gsm_objclass2mo(): Change signature/set NACK cause ...................................................................... Patch Set 6: Code-Review+1 (2 comments) File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/32075/comment/6743426b_931d4193 PS6, Line 544: mo = gsm_objclass2mo(bts, foh->obj_class, &foh->obj_inst, NULL); you could also pass a enum cause here https://gerrit.osmocom.org/c/osmo-bts/+/32075/comment/771ae177_28122ff4 PS6, Line 547: return oml_fom_ack_nack(msg, NM_NACK_OBJINST_UNKN); and use it here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32075 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I37e6b23ed95260a8188910cf9754faffcba519c5 Gerrit-Change-Number: 32075 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Apr 2023 11:03:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment