Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/28085 ) Change subject: measurement: move SACCH detection to process_l1sap_meas_data() ...................................................................... Patch Set 1: (2 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/28085/comment/f844f8d9_a78e2786 PS1, Line 725: .is_sub = info_meas_ind->is_sub, this looks weird. You first set it and then use it to re-set it. Rather remove this line and do it together with condition: !info_meas_ind->is_sub && trx_sched_is_sacch_fn(lchan->ts, fn, true) https://gerrit.osmocom.org/c/osmo-bts/+/28085/comment/223c3f71_ee57235a PS1, Line 757: .is_sub = ph_data_ind->is_sub, same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/28085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I507e96ee34ac0f8b7a2a6f16a8c7f92bc467df60 Gerrit-Change-Number: 28085 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 May 2022 10:31:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment