Change in osmo-iuh[master]: asn1tostruct: fix defines getting redefined - gerrit-log

14 Nov 2022

Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30088
)

Change subject: asn1tostruct: fix defines getting redefined
......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3: 
...
  ACK. IIUC you didn't detect any code change
required after this change in the users of the lib? 
yes

...
  In any case it may make sense to apply the renaming
only for fields count > 1 (so that if there's 2 or more fields colliding, the first
one is kept the old way). 
Then we would actually change what the define does. Let's say you use the handy
ENHANCEDRELOCATIONCOMPLETEREQUESTIES_RANAP_EXTENDEDRNC_ID_PRESENT define from the example
in the commit message, then before this patch it means "(1 << 1)". After
this patch, if we keep the name of the define for the first entry and rename the second
one, it will mean "(1 << 0)".

I think it's best to cause an error if this really has been used somewhere and we did
not catch it since the behavior may not have been what the user intended in the first
place.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/30088
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I2ecae6789899952d1dc5691ab76907abeaa71c12
Gerrit-Change-Number: 30088
Gerrit-PatchSet: 3
Gerrit-Owner: osmith &lt;osmith(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 14 Nov 2022 15:30:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith &lt;osmith(a)sysmocom.de&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-MessageType: comment