Attention is currently required from: pespin.
1 comment:
Patchset:
ACK. IIUC you didn't detect any code change required after this change in the users of the lib?
yes
In any case it may make sense to apply the renaming only for fields count > 1 (so that if there's 2 or more fields colliding, the first one is kept the old way).
Then we would actually change what the define does. Let's say you use the handy ENHANCEDRELOCATIONCOMPLETEREQUESTIES_RANAP_EXTENDEDRNC_ID_PRESENT define from the example in the commit message, then before this patch it means "(1 << 1)". After this patch, if we keep the name of the define for the first entry and rename the second one, it will mean "(1 << 0)".
I think it's best to cause an error if this really has been used somewhere and we did not catch it since the behavior may not have been what the user intended in the first place.
To view, visit change 30088. To unsubscribe, or for help writing mail filters, visit settings.