Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38087?usp=email )
Change subject: Introduce hashtable to lookup bts by LAC ......................................................................
Patch Set 4:
(2 comments)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/38087/comment/57573871_0c10b968?usp=... : PS4, Line 281: default
Uh? I think it's clear it's the default value for this config? we already use this notation in some […]
I know about this notation in the VTY. I am wondering how could it be default if we do not permit setting these values (see the check below)? Not directly related to this patch, but I find this confusing.
Did some testing by starting osmo-bsc with a config file that contains no `location_area_code` parameter. OsmoBSC indeed started fine and prints `location_area_code 0x0000` in the VTY. If I store this config by issuing `write file` and start osmo-bsc with the generated file, I am getting:
``` Error occurred during reading the below line: location_area_code 0x0000
% LAC 0 is reserved by GSM 04.08 DNM FATAL Failed to parse the config file: 'doc/examples/osmo-bsc/osmo-bsc-minimal.cfg' (Invalid argument) (osmo_bsc_main.c:521) Bootstrapping the network failed. exiting. ```
https://gerrit.osmocom.org/c/osmo-bsc/+/38087/comment/3df0ae91_7f00c368?usp=... : PS4, Line 289: if (lac == GSM_LAC_RESERVED_DETACHED || lac == GSM_LAC_RESERVED_ALL_BTS) (this is the check I am talking about)
-
fixeria