Attention is currently required from: lynxis lazus.

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40590?usp=email )

Change subject: tests: add a simple gtpie_getie() test ......................................................................

Patch Set 4:

(22 comments)

File tests/gtp/gtpie_test.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/551b13f1_e60c3757?usp... : PS4, Line 113: union gtpie_member *ie[GTPIE_SIZE] = {}; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/16294d9b_e080cbc7?usp... : PS4, Line 114: union gtpie_member ie_elem[3] = {}; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/55bee9ec_806bef22?usp... : PS4, Line 119: OSMO_ASSERT(gtpie_getie(ie, 0, 0) == -1); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/db644da6_93131cab?usp... : PS4, Line 120: OSMO_ASSERT(gtpie_getie(ie, 0, 1) == -1); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/940ffaaf_dc013457?usp... : PS4, Line 122: OSMO_ASSERT(gtpie_getie(ie, GTPIE_ENODEB_ID, 0) == -1); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/5ca25c90_63a8b9e8?usp... : PS4, Line 123: OSMO_ASSERT(gtpie_getie(ie, GTPIE_ENODEB_ID, 1) == -1); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/990ba738_a575757c?usp... : PS4, Line 125: ie_elem[0].tv1.t = GTPIE_CAUSE; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/5e0a9e5b_6279dd5a?usp... : PS4, Line 126: ie_elem[0].tv1.v = GTPIE_CAUSE; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/1bf2ffcd_2587eccb?usp... : PS4, Line 127: ie[0] = &ie_elem[0]; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/148f1cf6_29415a2c?usp... : PS4, Line 129: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/58be1f89_e1694541?usp... : PS4, Line 130: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == -1); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/ac1933ba_2301f8c1?usp... : PS4, Line 133: ie_elem[1].tv1.t = GTPIE_CAUSE; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/5bb881bd_d1d844df?usp... : PS4, Line 134: ie_elem[1].tv1.v = GTPIE_CAUSE; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/b9d27743_dc80e748?usp... : PS4, Line 135: ie[2] = &ie_elem[0]; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/dbce2148_222c2b05?usp... : PS4, Line 137: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/1279b3ef_7fdb69ff?usp... : PS4, Line 138: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == 2); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/adbd6d49_0308800b?usp... : PS4, Line 141: ie_elem[2].tv1.t = GTPIE_CAUSE; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/81be968c_8d8242f5?usp... : PS4, Line 142: ie_elem[2].tv1.v = GTPIE_CAUSE; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/e7079a0b_67b2fa00?usp... : PS4, Line 143: ie[GTPIE_SIZE - 1] = &ie_elem[0]; please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/c2943bfc_51ec3e64?usp... : PS4, Line 145: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 0) == 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/d10a83e7_f0600786?usp... : PS4, Line 146: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 1) == 2); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ggsn/+/40590/comment/3c03c308_3a2a58bb?usp... : PS4, Line 147: OSMO_ASSERT(gtpie_getie(ie, GTPIE_CAUSE, 2) == GTPIE_SIZE - 1); please, no spaces at the start of a line