Attention is currently required from: daniel, kirr, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39815?usp=email ) Change subject: fake_trx: Allow setting sched RR priority for clckgen thread ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/target/trx_toolkit/clck_gen.py: https://gerrit.osmocom.org/c/osmocom-bb/+/39815/comment/8eecb95c_9d6b6c63?u… : PS3, Line 73: self._thread.sched_rr_prio = self.sched_rr_prio Why is this needed? You're already setting `self.sched_rr_prio` above and the `_worker()` will have access to it via `self`. I think you can safely drop this line. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39815?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3c7f36c17fc7b9cae1023b4a0ed37f983dc286dc Gerrit-Change-Number: 39815 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Mar 2025 18:19:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes