osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31439 )

Change subject: bsc: TC_ho_in_fail_mgw_mdcx_timeout: fixup ......................................................................

bsc: TC_ho_in_fail_mgw_mdcx_timeout: fixup

Fix that the test was torn down too early, before DLCX messages were received from OsmoBSC. This caused a race condition that sometimes failed the test with:

VirtMGW-MGCP-0(1996)@e5a096d6b4ff: Dynamic test case error: Sending data on the connection of port MGCP_CLIENT to 1999:MGCP failed. (Broken pipe)

Related: OS#5787 Fixes: 7a8594a8 ("bsc: TC_ho_in_fail_mgw_mdcx_timeout: new test") Change-Id: If47fa3e0204ce841c79a67dd78a1c53d04e4a586 --- M bsc/BSC_Tests.ttcn 1 file changed, 26 insertions(+), 0 deletions(-)

Approvals: osmith: Looks good to me, approved; Verified Jenkins Builder: Verified

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 9a2718a..b9182e3 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -6347,6 +6347,15 @@ if (g_pars.expect_ho_fail_lchan_est) { BSSAP.receive(tr_BSSMAP_HandoverFailure); setverdict(pass); + + /* When we let MGCP MDCX run into a timeout, it's still in the + * queue and additionally after BSSAP HandoverFailure, two DLCX + * get sent. */ + if (g_pars.ignore_mgw_mdcx) { + MGCP.receive(tr_MDCX); + MGCP.receive(tr_DLCX); + MGCP.receive(tr_DLCX); + } return; }