Attention is currently required from: neels.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35175?usp=email )

Change subject: mgcp_network: Improve err logging when rtp pkt from unexpected origin comes in ......................................................................

Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/d77bbf72_fdd119b9 PS1, Line 8:

could you include some before and after log output?

I'm not following you here.

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/44488f75_0fb01cf3 PS1, Line 873: osmo_sockaddr_to_str(addr), osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf));

+1 for slashing LOGPC 👍 […]

I used osmo_sockaddr_ntop on purpose since we are only interested about the wrong IP address there, not the port.

https://gerrit.osmocom.org/c/osmo-mgw/+/35175/comment/178e1eaf_465dec47 PS1, Line 885: osmo_sockaddr_to_str(addr), osmo_sockaddr_port(&conn->end.addr.u.sa), It's printing the port of *another* address. See the check between "got" and "expected" there.

(completely different question, should we even care where RTP is coming from)

if you don't care about audio injection, or having customers plugged to other calls due to bugs, sure.