Attention is currently required from: neels.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 8:

    could you include some before and after log output?

    I'm not following you here.

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #1, Line 873: osmo_sockaddr_to_str(addr), osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf));

    +1 for slashing LOGPC 👍 […]

    I used osmo_sockaddr_ntop on purpose since we are only interested about the wrong IP address there, not the port.

  • Patch Set #1, Line 885: osmo_sockaddr_to_str(addr), osmo_sockaddr_port(&conn->end.addr.u.sa),

    It's printing the port of *another* address. See the check between "got" and "expected" there.

    (completely different question, should we even care where RTP is coming from)

    if you don't care about audio injection, or having customers plugged to other calls due to bugs, sure.

To view, visit change 35175. To unsubscribe, or for help writing mail filters, visit settings.