Attention is currently required from: kirr. pespin has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39536?usp=email ) Change subject: trx_toolkit/*: Represent bursts as arrays instead of lists ...................................................................... Patch Set 1: Code-Review+1 (4 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/39536/comment/9f680289_2b3a4fd7?u… : PS1, Line 13: item as just byte, and by leveraging bytearray.translate, we can sped sped -> speed up? File src/target/trx_toolkit/data_msg.py: https://gerrit.osmocom.org/c/osmocom-bb/+/39536/comment/5c4d3857_f9657b3c?u… : PS1, Line 71: self.burst = burst # bytes|bytearray for ubit, array[b] for sbit, array[B] for usbit I don't really understand what you mean with this comment here. https://gerrit.osmocom.org/c/osmocom-bb/+/39536/comment/aae995a1_6d58e490?u… : PS1, Line 134: def usbit2sbit(bits): # array[B] -> array[b] sou one cannot declare a param type for an array as done previously by List? https://gerrit.osmocom.org/c/osmocom-bb/+/39536/comment/55548750_3c79688e?u… : PS1, Line 672: burst = array('B', burst) I wonder whether we'll probably want to have all this encapsulated into eg. SBits, UBits, etc. objects in the future, so that it does all this array mangling internally and conversion to other objects internally in the class. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39536?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7314e9e79752e06fa86b9e346a9beacc5e59579e Gerrit-Change-Number: 39536 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: kirr <kirr(a)nexedi.com> Gerrit-Comment-Date: Wed, 12 Feb 2025 18:10:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes