Attention is currently required from: kirr.

Patch set 1:Code-Review +1

View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 13: item as just byte, and by leveraging bytearray.translate, we can sped

    sped -> speed up?

• File src/target/trx_toolkit/data_msg.py:

  • Patch Set #1, Line 71: self.burst = burst # bytes|bytearray for ubit, array[b] for sbit, array[B] for usbit

    I don't really understand what you mean with this comment here.

  • Patch Set #1, Line 134: def usbit2sbit(bits): # array[B] -> array[b]

    sou one cannot declare a param type for an array as done previously by List?

  • Patch Set #1, Line 672: burst = array('B', burst)

    I wonder whether we'll probably want to have all this encapsulated into eg. SBits, UBits, etc. objects in the future, so that it does all this array mangling internally and conversion to other objects internally in the class.

To view, visit change 39536. To unsubscribe, or for help writing mail filters, visit settings.