Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30982 ) Change subject: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers) ...................................................................... Patch Set 5: (3 comments) File src/osmo-bsc/neighbor_ident_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30982/comment/d25222c7_7566934d PS3, Line 107: struct osmo_strbuf csv = { .buf = log_buf, comma separated value. I changed it to 'reply', hope that's better https://gerrit.osmocom.org/c/osmo-bsc/+/30982/comment/70b4e1bf_7dddd11f PS3, Line 109: .pos = log_buf, Without initializing `.pos`, the code breaks in case `OSMO_STRBUF_PRINTF` is never called. I have removed the line `.chars_needed`. https://gerrit.osmocom.org/c/osmo-bsc/+/30982/comment/70d5efdf_55148b73 PS3, Line 118: llist_for_each_entry(n, &bts->neighbors, entry) { Hmm alright. In the issue, Christian Balzano wrote a very specific example where the numbers of BTSs from the .cfg where printed without mentioning any others. I have adapted the patch to print all BTS numbers of BTSs that are configured locally and added a testcase checking on BTSs configured via CGI-PS, as well. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79aeffd93089086f57c66787fe20b439a4d8b6b4 Gerrit-Change-Number: 30982 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Jan 2023 21:23:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment