[M] Change in pysim[master]: transport/pcsc: Allow opening PC/SC readers by a regex of their name - gerrit-log

18 Dec 2023


      Attention is currently required from: dexter, fixeria, laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34960?usp=email )
Change subject: transport/pcsc: Allow opening PC/SC readers by a regex of their name
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File pySim/transport/pcsc.py:
https://gerrit.osmocom.org/c/pysim/+/34960/comment/d0e2c3d9_9e8c7ee4 
PS4, Line 44:             reader_number = int(opts.pcsc_dev)
Looks like the int() is redundant here, argparse will already store it as int due to the type:
...
pySim-prog.py:    parser.add_option("-p", "--pcsc-device", dest="pcsc_dev", type='int', metavar="PCSC"
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/34960?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I983f19c6741904c1adf27749c9801b44a03a5d78
Gerrit-Change-Number: 34960
Gerrit-PatchSet: 4
Gerrit-Owner: laforge laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Mon, 18 Dec 2023 12:00:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment