laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39832?usp=email )

Change subject: cosmetic: Improve comment with spec references in Cell Selection Parameters ......................................................................

cosmetic: Improve comment with spec references in Cell Selection Parameters

The fields are named using a specific formatting in TS 44.018 10.5.2.4, but use another formatting in eg. TS 45.008. Let's provide both so that a quick grep can match related code.

Change-Id: I2c1264ed97154a365ae3f6f9dc18031b7adad109 --- M include/osmocom/gsm/protocol/gsm_04_08.h 1 file changed, 4 insertions(+), 4 deletions(-)

Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved

diff --git a/include/osmocom/gsm/protocol/gsm_04_08.h b/include/osmocom/gsm/protocol/gsm_04_08.h index f919c2b..35b3427 100644 --- a/include/osmocom/gsm/protocol/gsm_04_08.h +++ b/include/osmocom/gsm/protocol/gsm_04_08.h @@ -973,12 +973,12 @@ #endif } __attribute__ ((packed));

-/* Section 10.5.2.4 Cell Selection Parameters */ +/* 3GPP TS 44.018 Section 10.5.2.4 Cell Selection Parameters */ struct gsm48_cell_sel_par { #if OSMO_IS_LITTLE_ENDIAN - uint8_t ms_txpwr_max_ccch:5, /* GSM 05.08 MS-TXPWR-MAX-CCCH */ - cell_resel_hyst:3; /* GSM 05.08 CELL-RESELECT-HYSTERESIS */ - uint8_t rxlev_acc_min:6, /* GSM 05.08 RXLEV-ACCESS-MIN */ + uint8_t ms_txpwr_max_ccch:5, /* MS-TXPWR-MAX-CCH, 3GPP TS 45.008 MS_TXPWR_MAX_CCH */ + cell_resel_hyst:3; /* CELL-RESELECT-HYSTERESIS, 3GPP TS 45.008 CELL_RESELECT_HYSTERESIS */ + uint8_t rxlev_acc_min:6, /* RXLEV-ACCESS-MIN, 3GPP TS 45.008 RXLEV_ACCESS_MIN */ neci:1, acs:1; #elif OSMO_IS_BIG_ENDIAN