Attention is currently required from: daniel, pespin.

neels has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39239?usp=email )

Change subject: mgw: MDCX: Split mgcp header pars parsing into a previous step ......................................................................

Patch Set 4: Code-Review+1

(3 comments)

File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/39239/comment/d7c34176_d28bfd0e?usp=... : PS4, Line 1122: remote_osmux_cid = mgcp_osmux_setup(endp, line);

It is not needed and it was actually a bug due to messy code before this. […]

Done

https://gerrit.osmocom.org/c/osmo-mgw/+/39239/comment/b8350c7f_2775d13d?usp=... : PS4, Line 1088: return create_err_response(rq->trunk, NULL, -rc, "MDCX", pdata->trans); (future todo: add counter. (repeating comment from earlier patch))

https://gerrit.osmocom.org/c/osmo-mgw/+/39239/comment/d2be2b65_8bdfa262?usp=... : PS4, Line 1115: /* Reset conn mode in case it was tweaked through VTY: */ erm having trouble imagining how vty can tweak an incoming MDCX message... what am i missing