fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38030?usp=email )
Change subject: pfcp_peer: fix incorrect order of logging arguments ......................................................................
pfcp_peer: fix incorrect order of logging arguments
Change-Id: I4c2326d7143e8d4035d75cc60b53fc8cf33611cb --- M src/pfcp_peer.erl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified
diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index 8c29a9f..c97304b 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -303,10 +303,10 @@ -spec decode_pdu(binary(), tuple(), peer_state()) -> pfcp_pdu(). decode_pdu(Data, {FromIp, FromPort}, _S) -> ?LOG_DEBUG("Rx encoded PFCP PDU from ~p:~p: ~p", - [Data, FromIp, FromPort]), + [FromIp, FromPort, Data]), PDU = pfcp_packet:decode(Data), ?LOG_DEBUG("Rx PFCP PDU from ~p:~p: ~p", - [PDU, FromIp, FromPort]), + [FromIp, FromPort, PDU]), %% TODO: check PDU#pfcp.seq_no %% TODO: there can be batched PDUs PDU.