Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912 )

Change subject: cbc: Test ETWS msg over CBSP ......................................................................

Patch Set 4: Code-Review+1

(2 comments)

File cbc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/4c6f2626_51405... PS3, Line 101: var template (omit) uint8_t channel_ind := omit;

I gave this another try and indeed it seems to be fine passing the optional param directly, I must h […]

Done

File cbc/CBC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28912/comment/17c00c5f_3fe00... PS3, Line 353: g_pars.exp_cbs_msg.channel_ind

Same here, better use isbound().

In this particular place you may hit DTE if g_pars.exp_cbs_msg is omit. This is not a problem if g_pars.exp_cbs_msg is guaranteed to be present.