Attention is currently required from: osmith, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29285 ) Change subject: Introduce Osmux support ...................................................................... Patch Set 9: (4 comments) File configure.ac: https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/fe138a1c_2c86629a PS8, Line 81: #FIXME: ^ it actually needs > 1.2.0 No, because 1.3.0 is not yet released. This must be changed once libosmo-netif 1.3.0 is released, most probably during osmo-bts release time File doc/manuals/chapters/osmux_bts.adoc: https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/5e8e08db_1cebf7c5 PS8, Line 3: === Osmux Support in {program-name} Because it ensures in an easy way that all text uses the same format for the name. Furthermore, the program-name is used in the common included adoc above. File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/9b45cafb_df201af2 PS8, Line 292: /* FIXME: not needed? YES,we probably need to iterare over : bts->osmux.osmux_handle_list and free everything there, see : osmux_handle_put() */ I prefer merging as it is and coming back to this later, since I have to maintain stuff (branches) in osmo-bsc, osmo-bts, libosmo-netif, etc. https://gerrit.osmocom.org/c/osmo-bts/+/29285/comment/8db792b0_b0d7cdbe PS8, Line 355: were Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29285 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib80be434c06d07b3611bd18ae25dff8b14a7aad9 Gerrit-Change-Number: 29285 Gerrit-PatchSet: 9 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 15:33:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment