Attention is currently required from: osmith, dexter.

4 comments:

File configure.ac:
- Patch Set #8, Line 81: #FIXME: ^ it actually needs > 1.2.0
  looks like this can be done before merge, change ">=" to ">"?
  No, because 1.3.0 is not yet released. This must be changed once libosmo-netif 1.3.0 is released, most probably during osmo-bts release time
File doc/manuals/chapters/osmux_bts.adoc:
- Patch Set #8, Line 3: === Osmux Support in {program-name}
  just curious, why use {program-name} here and below? the text below is specific to OsmoBTS, right?
  Because it ensures in an easy way that all text uses the same format for the name. Furthermore, the program-name is used in the common included adoc above.
File src/common/osmux.c:
- Patch Set #8, Line 292:
```
/* FIXME: not needed? YES,we probably need to iterare over
	   bts->osmux.osmux_handle_list and free everything there, see
	   osmux_handle_put() */
```
  did you leave this intentionally / maybe not much effort to implement this instead of having the fix […]
  I prefer merging as it is and coming back to this later, since I have to maintain stuff (branches) in osmo-bsc, osmo-bts, libosmo-netif, etc.
- Patch Set #8, Line 355: were
  where
  Ack

To view, visit change 29285. To unsubscribe, or for help writing mail filters, visit settings.