[S] Change in libosmo-netif[master]: stream (test): Fix Coverity CID 323456 - gerrit-log

5 Oct 2023


      Attention is currently required from: arehbein.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34671?usp=email )
Change subject: stream (test): Fix Coverity CID 323456
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File tests/stream/stream_test.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/34671/comment/a4d7729e_1e75ea35 
PS1, Line 681: 	if (5 < ipa_msg_type) {
this syntax for comparision is a bit weird imho. I'd say we usually have the vars on the left side.
That's basically: "if (ipa_msg_type > 5)" right?
not criticial though.
-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34671?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2efb28feae4d4fa7516702f01026af09aa3777ac
Gerrit-Change-Number: 34671
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: arehbein arehbein@sysmocom.de
Gerrit-Comment-Date: Thu, 05 Oct 2023 16:54:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment