Attention is currently required from: neels.
fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/37993?usp=email )
Change subject: coverity CID#313611 ......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-pfcp/pfcp_msg.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/37993/comment/7c64151e_bb53180d?... : PS1, Line 589: struct osmo_fsm_inst *fi = m ? (m->ctx.session_fi ?: m->ctx.peer_fi) : NULL; Checking `m` against `NULL` below and returning early makes these ternary checks redundant. I suggest moving the variable assignments below the if-block you're adding.