Attention is currently required from: pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/33606
)
Change subject: ASCI: Do not wait for RLL establishment
......................................................................
Patch Set 3:
(2 comments)
File src/osmo-bsc/lchan_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/33606/comment/6a4e8db0_0ed14f4c
PS2, Line 1046: || lchan->activate.info.activ_for == ACTIVATE_FOR_VGCS_CHANNEL)
&& !requires_rtp_stream) {
wrong indentation. Also, you can move the 3rd cndition
to a new line too.
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/33606/comment/7cf918ae_56fdca93
PS2, Line 1070: if (lchan->sapis[0] != LCHAN_SAPI_UNUSED ||
lchan->activate.info.activ_for == ACTIVATE_FOR_VGCS_CHANNEL)
it would be clearer moving the new extra condition to
a new line.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/33606
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I96390924736029b92e54590157e38093be749dd9
Gerrit-Change-Number: 33606
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Jul 2023 11:41:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment