Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35563?usp=email ) Change subject: Add support for sending and receiving Sa bits, as well as some line signals ...................................................................... Patch Set 1: (16 comments) File src/input/e1d.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/7b982e26_e313cb4a PS1, Line 81: struct e1inp_line *e1i_line; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/e28bf67a_4d3119ee PS1, Line 81: struct e1inp_line *e1i_line; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/1ac5acb5_44812c23 PS1, Line 83: /* iterate over global list of e1 lines */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/f862f0ce_22934153 PS1, Line 84: llist_for_each_entry(e1i_line, &e1inp_line_list, list) { code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/1b88b87b_ca1b8a42 PS1, Line 84: llist_for_each_entry(e1i_line, &e1inp_line_list, list) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/a78ab10b_a566a23e PS1, Line 85: if (e1i_line->port_nr == port_nr) code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/3b721756_ef6c9939 PS1, Line 85: if (e1i_line->port_nr == port_nr) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/0ec7ecb0_2feb1a06 PS1, Line 86: return e1i_line; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/4710df86_4e0b3bae PS1, Line 86: return e1i_line; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/77be6ac8_cbb9ec1f PS1, Line 87: } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/b25f9f9f_9e3abb27 PS1, Line 87: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/f3d77ce6_8e329110 PS1, Line 88: return NULL; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/38a4cfa3_21f021c3 PS1, Line 88: return NULL; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/b132a521_bb3d0d2f PS1, Line 97: memset(&isd, 0, sizeof(isd)); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/47b5f222_598163f5 PS1, Line 97: memset(&isd, 0, sizeof(isd)); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558): https://gerrit.osmocom.org/c/libosmo-abis/+/35563/comment/a54b8dc4_89ae6d0e PS1, Line 106: switch (event) { switch and case should be at the same indent -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35563?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ie7643693c2daac99f5747591decd60e982b8052a Gerrit-Change-Number: 35563 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sun, 14 Jan 2024 15:17:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment