View Change

16 comments:

• File src/input/e1d.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 81: struct e1inp_line *e1i_line;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 81: struct e1inp_line *e1i_line;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 83: /* iterate over global list of e1 lines */

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 84: llist_for_each_entry(e1i_line, &e1inp_line_list, list) {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 84: llist_for_each_entry(e1i_line, &e1inp_line_list, list) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 85: if (e1i_line->port_nr == port_nr)

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 85: if (e1i_line->port_nr == port_nr)

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 86: return e1i_line;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 86: return e1i_line;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 87: }

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 87: }

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 88: return NULL;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 88: return NULL;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 97: memset(&isd, 0, sizeof(isd));

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 97: memset(&isd, 0, sizeof(isd));

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13558):

    Patch Set #1, Line 106: switch (event) {

    switch and case should be at the same indent

To view, visit change 35563. To unsubscribe, or for help writing mail filters, visit settings.