Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536 ) Change subject: Workaround bug where old hnb_context from same remote addr+port is kept ...................................................................... Patch Set 2: (3 comments) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536/comment/c3a06a27_fa7c5819 PS2, Line 426: if (hnb->hnb_registered && ctx != hnb && memcmp(&ctx->id, &hnb->id, sizeof(ctx->id)) == 0) { that'd be a separate path in any case, I'm not really touching this line in this patch. https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536/comment/d1907fc0_47ba37d3 PS2, Line 428: bug Yes, it's a bug, this is not expected to happen. See SYS#6113. I think I already provided a fix for the bug, but in case we have a similar one, this should at least keep the HNB ongoing in production despite of having such a bug. https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536/comment/96776812_5b6591ac PS2, Line 434: LOGHNB(ctx, DHNBAP, LOGL_ERROR, "BUG! Found old registered HNB with invalid socket, releasing it\n"); You get that info when the loop finished, because you see the message NB-REGISTER-REQ... -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I33ae901cc37646eca90bf06953e44fcc25f4d6c6 Gerrit-Change-Number: 29536 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 14:54:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment