Attention is currently required from: neels.

View Change

3 comments:

• File src/osmo-hnbgw/hnbgw_hnbap.c:

  • Patch Set #2, Line 426: if (hnb->hnb_registered && ctx != hnb && memcmp(&ctx->id, &hnb->id, sizeof(ctx->id)) == 0) {

    (early-exit coding style would be nicer like […]

    that'd be a separate path in any case, I'm not really touching this line in this patch.

  • Patch Set #2, Line 428: bug

    is it really a bug?? […]

    Yes, it's a bug, this is not expected to happen. See SYS#6113.
    I think I already provided a fix for the bug, but in case we have a similar one, this should at least keep the HNB ongoing in production despite of having such a bug.

  • Patch Set #2, Line 434: LOGHNB(ctx, DHNBAP, LOGL_ERROR, "BUG! Found old registered HNB with invalid socket, releasing it\n");

    IMHO the error logs could more clearly indicate that the same HNB is registering a second time, that […]

    You get that info when the loop finished, because you see the message NB-REGISTER-REQ...

To view, visit change 29536. To unsubscribe, or for help writing mail filters, visit settings.