pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/39347?usp=email )
Change subject: gsmtap: Increase txqueue max_length from 64 to 1024 ......................................................................
gsmtap: Increase txqueue max_length from 64 to 1024
The default value may be too low for main loop iterations writing a lot of output. Increase it to a saner value.
Change-Id: Ie737e1d060ea3ee48631604bbae1b8b84cf787b9 (cherry picked from commit 5edb7d54a8265ad6f44afdd0d07eda041f54ed98) --- M src/core/gsmtap_util.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: neels: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified
diff --git a/src/core/gsmtap_util.c b/src/core/gsmtap_util.c index b64c7b0..62d3ffa 100644 --- a/src/core/gsmtap_util.c +++ b/src/core/gsmtap_util.c @@ -496,8 +496,8 @@ if (osmo_iofd_register(gti->out, gti->wq.bfd.fd) < 0) goto err_cleanup;
- /* osmo write queue previously used was set up with value of 64 */ - osmo_iofd_set_txqueue_max_length(gti->out, 64); + /* Use a big enough tx queue to avoid gsmtap messages being dropped: */ + osmo_iofd_set_txqueue_max_length(gti->out, 1024); }
return gti;