Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/38254?usp=email )
Change subject: tests: sanitize all cards before running tests ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Do we have some information how much time the restore of all cards takes?
File tests/card_sanitizer/restore.script:
https://gerrit.osmocom.org/c/pysim/+/38254/comment/70dea27c_d511b702?usp=ema... : PS1, Line 3: ru I don't like this approach with a global file in /var/tmp. What if for some reason there's two jobs running by accident? what if somebody else can write to that file?
If you must use a temp file, I would suggest it to be created with mkstem(3) or mktemp(1) or some python equivalent thereof.
But wouldn't it be much simpler to introduce something like a @-e@ command line argument to pySim-shell, which could be used multiple times to specify multiple commands? Then you could do `pySim-shell -e verify_adm -e run_script /my/path/to/full.script > /dev/null`
See https://gerrit.osmocom.org/c/pysim/+/38255