Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/28632
)
Change subject: move EF_UServiceTable from ts_31_102 to ts_31_102_telecom
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/28632/comment/442d71ff_d0bc7933
PS1, Line 10: avoid cyclic imports
Not sure if this is a problem when you import specific
API from a module, rather than doing 'import […]
it is. We are and have always
been using selective imports between ts_51_011.py and ts_31_102.py, but still it
doesn't work if ts_31_102.py imports some classes from ts_51_011 and we now add the
inverse to it :(
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/28632
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9cd6ab795bfd92f845eb943679a3d6302f1003ce
Gerrit-Change-Number: 28632
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Jul 2022 07:34:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment