[L] Change in libosmo-netif[master]: stream: Add server-side (segmentation) support for IPAC - gerrit-log

25 Jun 2023

Attention is currently required from: laforge.

arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33197 )

Change subject: stream: Add server-side (segmentation) support for IPAC
......................................................................

Patch Set 2:

(4 comments)

File include/osmocom/netif/stream.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/3053efbe_8f19eccb 
PS1, Line 25: osmo_stream_proto
...
  The naming is unfortunately not good, IMHO. […]
I have for now put `osmo_stream_trx_mode` instead; the name should be more general
than just referring to segmentation, because in later commits, setting these kinds of
values also sets the read/write callbacks for IPA which automatically pull/push IPA
headers.

Hope that's better, if not, please make another suggestion.

https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/44671da8_2f4d7c1e 
PS1, Line 28: 	/* TODO: Add protocols for 
...
  I don't think there are any others, so it's
not a TODO. […] Done.

What functionality did you have in mind as missing? Please note that this commit is for
adding segmentation only.

File src/stream.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/bcbe07ce_2b71f314 
PS1, Line 1777: 	conn->iofd = osmo_iofd_setup(conn, fd, name,
OSMO_IO_FD_MODE_READ_WRITE,
...
  unrelated whitespace change? Done

File tests/stream/stream_test.c:

https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/f35c379b_dc8a2fab 
PS1, Line 2:  * (C) 2019 by sysmocom - s.f.m.c. GmbH.
...
  in case of significant changes, it makes sense to
update the copyright year and also to add yourself […] Done

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33197
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c
Gerrit-Change-Number: 33197
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein &lt;arehbein(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Comment-Date: Sun, 25 Jun 2023 17:01:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-MessageType: comment