Attention is currently required from: laforge.

View Change

4 comments:

• File include/osmocom/netif/stream.h:

  • Patch Set #1, Line 25: osmo_stream_proto

    The naming is unfortunately not good, IMHO. […]

    I have for now put `osmo_stream_trx_mode` instead; the name should be more general than just referring to segmentation, because in later commits, setting these kinds of values also sets the read/write callbacks for IPA which automatically pull/push IPA headers.

    Hope that's better, if not, please make another suggestion.

  • Patch Set #1, Line 28: /* TODO: Add protocols for

    I don't think there are any others, so it's not a TODO. […]

    Done.

    What functionality did you have in mind as missing? Please note that this commit is for adding segmentation only.

• File src/stream.c:

  • Patch Set #1, Line 1777: conn->iofd = osmo_iofd_setup(conn, fd, name, OSMO_IO_FD_MODE_READ_WRITE,

    unrelated whitespace change?

    Done

• File tests/stream/stream_test.c:

  • Patch Set #1, Line 2: * (C) 2019 by sysmocom - s.f.m.c. GmbH.

    in case of significant changes, it makes sense to update the copyright year and also to add yourself […]

    Done

To view, visit change 33197. To unsubscribe, or for help writing mail filters, visit settings.