Attention is currently required from: dexter, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/36356?usp=email )
Change subject: remove strange loop for non-existant transcoding support
......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/36356/comment/386b9c79_d1c57b9e
PS1, Line 1178: rc = endp->trunk->cfg->rtp_processing_cb(endp, rtp_end, (char
*)msgb_data(msg), &buflen, RTP_BUF_SIZE);
You may was well drop the entire think which afaict is
only used with cb mgcp_rtp_processing_default […]
yes, I thought about that, too.
But I dedided to keep it without the loop for now. Given there are more patches on top of
this, I'd avoid not having to rewrite and sort out all the clashes of the patches on
top. The goal here is to get osmo_io/io_uring working, not a more fundmental cleanup of
osmo-mgw.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/36356?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ie1a629fd31c5ab806fc929d1e6b279c4be5b8246
Gerrit-Change-Number: 36356
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 20 Mar 2024 12:55:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment