Attention is currently required from: fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email )
Change subject: pcu_l1_if: signal BTS model via PCUIF
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Thanks for testing this. I will prepare new releases for osmo-bts and osmo-bsc then.
either drop backwards compatibility with PCUIFv <
12 (see
https://cgit.osmocom.org/osmo-pcu/commit/?id=46140948d9800bca6a7b4299f08b25…), or
keep it compatible with v10 and v11, but carefully check that it can actually work with
v10 and v12.
I didn't realize earlier that not only the patch drops backwards compat for PCUIFv11
as the commit message says, but also it adds a "if (info_ind->version !=
PCU_IF_VERSION) {" check so starting with this patch, there will be no more backwards
compatibility to pcuif.
I'll add this patch to osmo-pcu v1.4.0 then, given that the mixing the versions is not
tested and will also not be supported anymore once we tag a new release from master.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: osmith/1.4.0
Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047
Gerrit-Change-Number: 35318
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Dec 2023 12:23:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment