Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33123 ) Change subject: encoding: only RFN needed in write_immediate_assignment(_reject)() ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/33123/comment/0822cf34_bd167880 PS1, Line 7: RFN needed in write_immediate_assignment(_reject)() I don't understand you here. RFN is actually the result of the reduced encoding performed by these functions. This encoding itself does not require the input to be absolute or reduced Fn, it does not really matter. Not sure what do we benefit with this change? https://gerrit.osmocom.org/c/osmo-pcu/+/33123/comment/717b7298_01ded1cd PS1, Line 12: 10.5.2.30 3GPP TS 44.018? File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/33123/comment/795ddf82_1eed4747 PS1, Line 1121: GSM_TDMA_FN_SUM I think you can remove the `GSM_TDMA_FN_SUM` now and simply do: ``` fn2rfn(pdch->last_rts_fn + 21216) ``` BTW, I just realized that `21216` is `RFN_MODULUS / 2`. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If9b758434c00f2a3868534d5be84946809c989a9 Gerrit-Change-Number: 33123 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Jun 2023 07:56:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment