Attention is currently required from: osmith, neels, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31513 ) Change subject: GSMTAP: allow configuring src IP for log messages ...................................................................... Patch Set 12: Code-Review-1 (4 comments) File src/core/logging_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/e5018e7d_286b2311 PS12, Line 132: gsmtap_source_free(target->tgt_gsmtap.gsmtap_inst); You could try comparing if new ip if same as the old one and then do nothing. Otherwise you are recreating the whole thing every time you enter the VTY node (potentially recreating the socket?) https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/bea02783_56d5fb24 PS12, Line 139: if (ip) if without {} and else with them. Fix. https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/89db26fd_92b61a6f PS12, Line 186: target->tgt_gsmtap.src_addr = talloc_strdup(target, src); I hope arget->tgt_gsmtap.src_addr is NULL here and we are not leaking. File utils/osmo-stat-dummy/osmo-stat-dummy.cfg: https://gerrit.osmocom.org/c/libosmocore/+/31513/comment/c858fd48_6e927ac2 PS4, Line 1: log gsmtap 127.0.0.69 127.6.9.1 1- 127.0.0.1/8 always exist on linux for IPv4 (not even the case for IPv6 iirc). 2- I still don't see the point on why do you want to set a specific source IP address there. As a default, letting the kernel decide the src IP address based on current routing table is a better solution as per user expectancies. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9000269ce5b3dce1e757271b7c42e77b68d38f25 Gerrit-Change-Number: 31513 Gerrit-PatchSet: 12 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:33:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment