Attention is currently required from: osmith, neels, fixeria, msuraev.

Patch set 12:Code-Review -1

View Change

4 comments:

• File src/core/logging_gsmtap.c:

  • Patch Set #12, Line 132: gsmtap_source_free(target->tgt_gsmtap.gsmtap_inst);

    You could try comparing if new ip if same as the old one and then do nothing. Otherwise you are recreating the whole thing every time you enter the VTY node (potentially recreating the socket?)

  • Patch Set #12, Line 139: if (ip)

    if without {} and else with them. Fix.

  • Patch Set #12, Line 186: target->tgt_gsmtap.src_addr = talloc_strdup(target, src);

    I hope arget->tgt_gsmtap.src_addr is NULL here and we are not leaking.

• File utils/osmo-stat-dummy/osmo-stat-dummy.cfg:

  • Patch Set #4, Line 1: log gsmtap 127.0.0.69 127.6.9.1

    Not sure I'm following - 127.0.0.1/8 always exist. […]

    1- 127.0.0.1/8 always exist on linux for IPv4 (not even the case for IPv6 iirc).
    2- I still don't see the point on why do you want to set a specific source IP address there. As a default, letting the kernel decide the src IP address based on current routing table is a better solution as per user expectancies.

To view, visit change 31513. To unsubscribe, or for help writing mail filters, visit settings.