Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30986 )
Change subject: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen() ......................................................................
Patch Set 2: Code-Review+1
(6 comments)
Patchset:
PS2: None of my comments are critical, can be done in a subsequent patch.
File src/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/9a603c26_fc9ddef0 PS2, Line 1304: 4 sizeof(uint32_t)
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/6dfa6aad_e012b3ba PS2, Line 1306: cosmetic: no need for a space
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/332f182b_17cb458c PS2, Line 1307: 4 sizeof(bits) or sizeof(uint32_t)
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/e76c9c92_e89eef18 PS2, Line 1323: cosmetic: no need for a space
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/d93ba7e9_0eef5f5c PS2, Line 1326: 4 sizeof(bits) or sizeof(uint32_t)