Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30986 )
Change subject: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen()
......................................................................
Patch Set 2: Code-Review+1
(6 comments)
Patchset:
PS2:
None of my comments are critical, can be done in a subsequent patch.
File src/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/9a603c26_fc9ddef0
PS2, Line 1304: 4
sizeof(uint32_t)
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/6dfa6aad_e012b3ba
PS2, Line 1306:
cosmetic: no need for a space
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/332f182b_17cb458c
PS2, Line 1307: 4
sizeof(bits) or sizeof(uint32_t)
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/e76c9c92_e89eef18
PS2, Line 1323:
cosmetic: no need for a space
https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/d93ba7e9_0eef5f5c
PS2, Line 1326: 4
sizeof(bits) or sizeof(uint32_t)
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30986
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I75e75e251c6776801fffdde745aebedf21c68799
Gerrit-Change-Number: 30986
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Jan 2023 18:32:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment