Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27217 ) Change subject: libosmo-tlv: add versatile TLV de- and encoder ...................................................................... Patch Set 3: Code-Review-1 (1 comment) Patchset: PS3: as a general rule we don't introduce symbols or types with an osmo_ prefix into applications. This will likely clash with stuff from libraries. So we can either move this library to libosmocore (or a separate library git repo), and keep the osmo_ prefix, or we can keep it locally in-tree and then remove/rename the osmo_ prefix. If we move to libosmocore or a separate repo, we shuld also revisit the name. osmo_tlv and osmo_vtlv are already used with a different meaning in libosmocore. Maybe osmo_ntlv (new tlv)? ideas? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27217 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib0fd00d9f288ffe13b7e67701f3e47073587404a Gerrit-Change-Number: 27217 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 18 Mar 2022 10:59:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment