pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34616?usp=email ) Change subject: rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice) ...................................................................... rlcmac: tbf_ul: Fix wrong field assignment (no bug in practice) Fixes following warning detected by clang: """ tbf_ul.c:1118:37: warning: implicit conversion from enumeration type 'enum gprs_rlcmac_rlc_egprs_ul_reseg_bsn_state' to different enumeration type 'enum gprs_rlcmac_rlc_egprs_dl_reseg_bsn_state' [-Wenum-conversion] blk->spb_status.block_status_dl = reseg_status; """ In practice it's not much of a problem since both fields are put together in a union, so it ends up in the same place in memory. Change-Id: Iccd57b74640754f2aebf81a149a633f141c6e38f --- M src/rlcmac/tbf_ul.c 1 file changed, 21 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/rlcmac/tbf_ul.c b/src/rlcmac/tbf_ul.c index 3786b30..d96891f 100644 --- a/src/rlcmac/tbf_ul.c +++ b/src/rlcmac/tbf_ul.c @@ -1115,7 +1115,7 @@ * function returns the reseg status */ reseg_status = egprs_ul_get_data(ul_tbf, bsn, &block_data); - blk->spb_status.block_status_dl = reseg_status; + blk->spb_status.block_status_ul = reseg_status; /* * If it is first segment of the split block set the state of -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34616?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iccd57b74640754f2aebf81a149a633f141c6e38f Gerrit-Change-Number: 34616 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged