[M] Change in libosmo-sccp[master]: Forbid partial VTY configurations of ASPs with name asp-clnt-* - gerrit-log

20 Jun 2023

Attention is currently required from: pespin.

fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/33325 )

Change subject: Forbid partial VTY configurations of ASPs with name asp-clnt-*
......................................................................

Patch Set 2:

(1 comment)

File include/osmocom/sigtran/osmo_ss7.h:

https://gerrit.osmocom.org/c/libosmo-sccp/+/33325/comment/69a4670d_c2537d51 
PS2, Line 433: 		bool role_set_by_vty;
...
  1- Here I'm just readding some fields which used
to be there. 
So you're saying the API/ABI was already broken once, when the fields were removed?

...
  2- These fields (.cfg) are basically set by VTY code
which is also inside libosmo-sccp. Furthermore the ASP objects are allocated internally so
there's no problem with struct size changing. 
But I see for instance osmo-bsc.git is accessing `asp->cfg.proto` and
`asp->cfg.name`. You're not touching these in this patch, but the overall struct
layout gets changed, e.g. the compiler may rearrange padding.

Adding these new fields at the end of scope would be safer, IMO.

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33325
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I65b5fad2ec06a9d9c521f1e3ce8aab633da95a47
Gerrit-Change-Number: 33325
Gerrit-PatchSet: 2
Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Tue, 20 Jun 2023 11:31:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-MessageType: comment