Attention is currently required from: pespin.

View Change

1 comment:

• File include/osmocom/sigtran/osmo_ss7.h:

  • Patch Set #2, Line 433: bool role_set_by_vty;

    1- Here I'm just readding some fields which used to be there.

    So you're saying the API/ABI was already broken once, when the fields were removed?

    2- These fields (.cfg) are basically set by VTY code which is also inside libosmo-sccp. Furthermore the ASP objects are allocated internally so there's no problem with struct size changing.

    But I see for instance osmo-bsc.git is accessing `asp->cfg.proto` and `asp->cfg.name`. You're not touching these in this patch, but the overall struct layout gets changed, e.g. the compiler may rearrange padding.

    Adding these new fields at the end of scope would be safer, IMO.

To view, visit change 33325. To unsubscribe, or for help writing mail filters, visit settings.