[M] Change in osmo-bts[master]: Use polling based LAPDm with frame numbers - gerrit-log

20 Nov 2023

Attention is currently required from: fixeria.

jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email )

Change subject: Use polling based LAPDm with frame numbers
......................................................................

Patch Set 3:

(2 comments)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/cd959b91_89f25947 
PS2, Line 1975: (fn + GSM_MAX_FN - 1) % GSM_MAX_FN
...
  Feel free to use `GSM_TDMA_FN_SUB(fn, 1)` here.
Done

File src/common/oml.c:

https://gerrit.osmocom.org/c/osmo-bts/+/35007/comment/51f31218_7bc5bd69 
PS3, Line 686: #if 0
...
  IMO, we should at least log a `NOTICE` message here
saying that the T200 values from the BSC and ign […] Yes, this makes sense.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic6d7902b13cf491daaa8752db78f9875387aeffd
Gerrit-Change-Number: 35007
Gerrit-PatchSet: 3
Gerrit-Owner: jolly &lt;andreas(a)eversberg.eu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 20 Nov 2023 13:21:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-MessageType: comment