Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38091?usp=email )
Change subject: pcuif: fix TXT_IND/PCU_VERSION BTS initialization behavior ......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/pcu_sock.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18448): https://gerrit.osmocom.org/c/osmo-bsc/+/38091/comment/0dd377ce_b4a95249?usp=... : PS1, Line 687: LOGP(DPCU, LOGL_ERROR, "Unknown TXT_IND type %u received\n", code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-18448): https://gerrit.osmocom.org/c/osmo-bsc/+/38091/comment/e1756257_2065e479?usp=... : PS1, Line 705: #define ENSURE_BTS_OBJECT() \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects