Attention is currently required from: pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32196 )

Change subject: nm: Drop NM_EV_SETATTR_{ACK/NACK} ......................................................................

Patch Set 3:

(4 comments)

File src/osmo-bts-lc15/oml.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32196/comment/7a1430ad_a349709d PS3, Line 1851: rc = 0; This is weird. Why not simply `return 0` down below?

https://gerrit.osmocom.org/c/osmo-bts/+/32196/comment/1d29845b_f3a0fa77 PS3, Line 1854: rc = 0; So it's fine if we get an unknown/unhandled `foh->msg_type` value?

File src/osmo-bts-sysmo/oml.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32196/comment/96cb51f2_a1ce52c8 PS3, Line 1726: case NM_MT_SET_RADIO_ATTR: `rc` is uninitialized in this case. I suggest removing it and simply doing `return 0` below.

File src/osmo-bts-virtual/bts_model.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32196/comment/91e6280f_c4898f67 PS3, Line 148: rc = 0; Are you sure 0 is the right value here? Not `-ENOTSUP`?