Attention is currently required from: pespin.

View Change

4 comments:

• File src/osmo-bts-lc15/oml.c:

  • Patch Set #3, Line 1851: rc = 0;

    This is weird. Why not simply `return 0` down below?

  • Patch Set #3, Line 1854: rc = 0;

    So it's fine if we get an unknown/unhandled `foh->msg_type` value?

• File src/osmo-bts-sysmo/oml.c:

  • Patch Set #3, Line 1726: case NM_MT_SET_RADIO_ATTR:

    `rc` is uninitialized in this case. I suggest removing it and simply doing `return 0` below.

• File src/osmo-bts-virtual/bts_model.c:

  • Patch Set #3, Line 148: rc = 0;

    Are you sure 0 is the right value here? Not `-ENOTSUP`?

To view, visit change 32196. To unsubscribe, or for help writing mail filters, visit settings.