fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37111?usp=email )

Change subject: msc: do not execute TC_gsup_mt_sms_lu_delay against -latest ......................................................................

msc: do not execute TC_gsup_mt_sms_lu_delay against -latest

This patch fixes regressions in ttcn3-msc-test-latest caused by a recently merged patch adding MSC_Tests.TC_gsup_mt_sms_lu_delay.

I was expecting it to fail early at this line:

f_vty_config(MSCVTY, "msc", "timer geran X36 2500"); /* 2.5s */

since timer X36 is not available in the -latest yet. But this function executes just fine and the error response is simply ignored.

The -latest version of osmo-msc closes the A-connection early and then tries to deliver a MT SMS while executing subsequent testcases.

Change-Id: I0b07076a054e30c5a9023de18f2c70f15c97f8cc Fixes: 8d0d7af2 "msc: add TC_gsup_mt_sms_lu_delay for X36 (LU delay) timer" Related: SYS#6913 --- M msc/MSC_Tests.ttcn 1 file changed, 30 insertions(+), 1 deletion(-)

Approvals: osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve

diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 3c707d1..898aeef 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -17,6 +17,7 @@

import from General_Types all; import from Osmocom_Types all; +import from Misc_Helpers all; import from GSM_Types all;

import from M3UA_Types all; @@ -7493,7 +7494,11 @@ execute( TC_gsup_mt_sms_rp_mr() ); execute( TC_gsup_mo_mt_sms_rp_mr() ); execute( TC_gsup_mt_multi_part_sms() ); - execute( TC_gsup_mt_sms_lu_delay() ); + if (Misc_Helpers.f_osmo_repo_is("nightly")) { + /* timer X36 is not supported by osmo-msc <= 1.11.1 + * Related: osmo-msc.git Ic519cab55d65e47b2636124427dab1a1d80fab78 */ + execute( TC_gsup_mt_sms_lu_delay() ); + }

execute( TC_lu_and_mo_ussd_single_request() ); execute( TC_lu_and_mt_ussd_notification() );