Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32428 )
Change subject: layer23: modem: Unregister registered callbacks upon app exit ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmocom-bb/+/32428/comment/b3343486_975f7347 PS3, Line 7: layer23: modem: Unregister registered callbacks upon app exit
what's missing in the commit message is why doing this is necessary
It's just a good practice to delete all resources allocated during startup. The main aim here is to keep resemblance to what the mobile app is doing, so that they can slowly be merged and some functionalities from the mobile app can be added to the modem app, like shutting down the MS without killing the process eventually.