Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/32428 )
Change subject: layer23: modem: Unregister registered callbacks upon app exit
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmocom-bb/+/32428/comment/b3343486_975f7347
PS3, Line 7: layer23: modem: Unregister registered callbacks upon app exit
what's missing in the commit message is why doing
this is necessary
It's just a good practice to delete all resources allocated
during startup.
The main aim here is to keep resemblance to what the mobile app is doing, so that they can
slowly be merged and some functionalities from the mobile app can be added to the modem
app, like shutting down the MS without killing the process eventually.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/32428
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5a641fa3dadb6ea7346b25a20215896ab32eb805
Gerrit-Change-Number: 32428
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Apr 2023 11:54:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment